Re: [PATCH v2 02/10] drm/arm: malidp: Use fourcc_mod_is_vendor() helper
From: Daniel Vetter <hidden>
Date: 2021-06-09 18:27:51
Also in:
dri-devel
On Fri, Mar 26, 2021 at 03:51:31PM +0100, Thierry Reding wrote:
From: Thierry Reding <redacted> Rather than open-coding the vendor extraction operation, use the newly introduced helper macro. Signed-off-by: Thierry Reding <redacted>
On the first two patches: Reviewed-by: Daniel Vetter <redacted>
quoted hunk ↗ jump to hunk
--- drivers/gpu/drm/arm/malidp_planes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index ddbba67f0283..cd218883cff8 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c@@ -165,7 +165,7 @@ bool malidp_format_mod_supported(struct drm_device *drm, return !malidp_hw_format_is_afbc_only(format); } - if ((modifier >> 56) != DRM_FORMAT_MOD_VENDOR_ARM) { + if (!fourcc_mod_is_vendor(modifier, ARM)) { DRM_ERROR("Unknown modifier (not Arm)\n"); return false; }-- 2.30.2
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch