Thread (6 messages) 6 messages, 2 authors, 2021-06-18
STALE1806d
Revisions (2)
  1. v2 current
  2. v3 [diff vs current]

[PATCH v2 3/4] hwmon: (lm90) Unmask hardware interrupt

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-06-18 21:12:46
Also in: linux-hwmon, lkml
Subsystem: hardware monitoring, lm90 hardware monitor driver, the rest · Maintainers: Guenter Roeck, Jean Delvare, Linus Torvalds

The ALERT interrupt is enabled by default after power-on, but it could
be masked by bootloader. For example this is the case on Acer A500 tablet
device. Unmask the hardware interrupt if interrupt is provided.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/hwmon/lm90.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index e7b678a40b39..658b486d2f5e 100644
--- a/drivers/hwmon/lm90.c
+++ b/drivers/hwmon/lm90.c
@@ -1704,6 +1704,13 @@ static int lm90_init_client(struct i2c_client *client, struct lm90_data *data)
 	if (data->kind == max6696)
 		config &= ~0x08;
 
+	/*
+	 * Interrupt is enabled by default on reset, but it may be disabled
+	 * by bootloader, unmask it.
+	 */
+	if (client->irq)
+		config &= ~0x80;
+
 	config &= 0xBF;	/* run */
 	lm90_update_confreg(data, config);
 
-- 
2.30.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help