Re: [PATCH v1 1/5] ALSA: hda/tegra: Use clk_bulk helpers
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-01-17 23:32:36
Also in:
alsa-devel, lkml
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-01-17 23:32:36
Also in:
alsa-devel, lkml
15.01.2021 18:22, Thierry Reding пишет: ...
quoted
static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev) { struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip);@@ -495,7 +441,11 @@ static int hda_tegra_probe(struct platform_device *pdev) return err; } - err = hda_tegra_init_clk(hda); + hda->clocks[hda->nclocks++].id = "hda"; + hda->clocks[hda->nclocks++].id = "hda2hdmi"; + hda->clocks[hda->nclocks++].id = "hda2codec_2x";Originally the code did this in this order: "hda", "hda2codec_2x" and "hda2hdmi". I don't expect the exact order to be very relevant, but was there any particular reason to change it?
The reason was "to make code look nicer". This was a conscious decision since indeed the clocks order shouldn't matter for this driver.