Thread (17 messages) 17 messages, 4 authors, 2021-01-13

Re: [PATCH v3 0/9] Support Runtime PM and host mode by Tegra ChipIdea USB driver

From: Peter Chen <hidden>
Date: 2021-01-13 01:21:45
Also in: linux-usb, lkml

On 21-01-12 09:56:37, Dmitry Osipenko wrote:
29.12.2020 17:26, Dmitry Osipenko пишет:
quoted
29.12.2020 08:16, Peter Chen пишет:
quoted
On 20-12-18 15:02:37, Dmitry Osipenko wrote:
quoted
This series implements Runtime PM support for the Tegra ChipIdea USB driver.
It also squashes the older ehci-tegra driver into the ChipIdea driver, hence
the RPM is supported by both UDC and host controllers, secondly this opens
opportunity for implementing OTG support in the future.

Patchset was tested on various Tegra20, Tegra30 and Tegra124 devices.
Thanks to Peter Geis, Matt Merhar, Nicolas Chauvet and Ion Agorria for
helping with the extensive and productive testing!

Changelog:

v3: - Replaced "goto" with if-statements as was suggested by Thierry Reding.

    - Improved wording of the deprecated Kconfig entry as was suggested
      by Alan Stern.

    - Added ACKs from Thierry Reding and Alan Stern.

    - Added a new minor patch "Specify TX FIFO threshold in UDC SoC info"
      just for completeness, since we can now switch OTG to host mode in
      the ChipIdea driver. Although, OTG support remains a work-in-progress
      for now.

v2: - Improved comments in the code as it was suggested by Peter Chen and
      Sergei Shtylyov for v1.

    - Replaced mdelay() with fsleep() and made ci->hdc to reset to NULL in
      a error code path, like it was suggested by Peter Chen.

    - Redirected deprecated USB_EHCI_TEGRA Kconfig entry to USB_CHIPIDEA_TEGRA
      as was suggested by Alan Stern.

    - Improved commit message and added ACK from Thierry Reding to the patch
      that removes MODULE_ALIAS.

    - Fixed UDC PHY waking up on ASUS TF201 tablet device by utilizing
      additional VBUS sensor. This was reported and tested by Ion Agorria.

    - Added t-b from Ion Agorria.

Dmitry Osipenko (8):
  usb: phy: tegra: Add delay after power up
  usb: phy: tegra: Support waking up from a low power mode
  usb: chipidea: tegra: Remove MODULE_ALIAS
  usb: chipidea: tegra: Rename UDC to USB
  usb: chipidea: tegra: Support runtime PM
  usb: chipidea: tegra: Specify TX FIFO threshold in UDC SoC info
  usb: host: ehci-tegra: Remove the driver
  ARM: tegra_defconfig: Enable USB_CHIPIDEA_HOST and remove
    USB_EHCI_TEGRA

Peter Geis (1):
  usb: chipidea: tegra: Support host mode
Chipidea related (patch 3-7) are applied, thanks.
Hello Peter,

Thank you for applying the patches.

Who will apply the remaining patches?

The Chipidea patch #6 depends on the PHY changes, otherwise USB will
suspend and never resume.
Peter, could you please apply the PHY and defconfig patches along with
the CI patches to -next? I.e. the whole series. Preferentially in
original ordering of patches should be preserved.
Hi Dmitry,

Usually, Greg could apply all USB patches, if I apply other USB related
patches, it may cause conflict with other patches in other's tree.
Greg, free feel to apply this series with 
Acked-by: Peter Chen <peter.chen@kernel.org>
for chipidea part.

For ARM defconfig patch, I think it should go ARM's tree.

-- 

Thanks,
Peter Chen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help