Thread (7 messages) 7 messages, 3 authors, 2018-08-14

Re: [PATCH] soc/tegra: pmc: fix child-node lookup

From: Thierry Reding <hidden>
Date: 2018-08-14 14:25:00
Also in: lkml

On Mon, Aug 13, 2018 at 04:33:17PM +0200, Johan Hovold wrote:
Hi Thierry,

On Thu, Mar 22, 2018 at 03:24:32PM +0100, Thierry Reding wrote:
quoted
On Wed, Nov 15, 2017 at 10:44:58AM +0100, Johan Hovold wrote:
quoted
Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.

To make things worse, the parent pmc node could end up being prematurely
freed as of_find_node_by_name() drops a reference to its first argument.

Fixes: 3568df3d31d6 ("soc: tegra: Add thermal reset (thermtrip) support to PMC")
Cc: stable <redacted>     # 4.0
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/soc/tegra/pmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
I noticed this one still hasn't made it into linux-next. Looks like it
wasn't included in you 4.17 pull request and is still sitting in the
tegra for-4.17/soc branch.
Indeed. Looking at my tree it seems like I applied this to for-4.17/soc
a couple of days after the signed tag for the pull request. It probably
should've gone into a for-4.18/soc, or perhaps into fixes pull request.

I've cherry-picked it into for-4.20/soc now. Thanks for the reminder.

Thierry

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help