Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

On 14.02.2018 14:15, Peter De Schrijver wrote:

On Tue, Feb 13, 2018 at 11:30:39AM +0100, Thierry Reding wrote:

quoted

quoted

 	}

It's odd that we don't have an MC clock on Tegra2. I wonder if perhaps
we just never implemented one, or it uses one which is always on by
default. Cc Peter to see if he knows.

We do, it has DT ID TEGRA20_CLK_MC. However, it looks like the modeling is
incorrect for Tegra20. Unlike on Tegra30 where the MC clock can be either
half or the same as the EMC clock, it is always half the EMC clock on
Tegra20. This happens to work because we likely never change the MC clock
and the non-existing bit just reads as 0, which means half the MC clock.

Yes, and also that clock isn't specified in DT for MC. So probably we would have
to use clk_get_sys even if it was implemented correctly.