On Tue, Aug 1, 2017 at 10:53 AM, Linus Walleij [off-list ref] wrote:

On Mon, Jul 31, 2017 at 4:04 PM, Andy Shevchenko
[off-list ref] wrote:

quoted

On Mon, 2017-07-31 at 15:48 +0200, Linus Walleij wrote:

quoted

On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko
[off-list ref] wrote:

quoted

quoted

quoted

If Linus is okay with the following proposal I would rather go with
it,
i.e. logical split the series to

1. Fix IRQ related headers inclusion
2. Fix pinconf-generic.h inclusion
3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?)

That works fine with me, but also one big patch actually, I do not
want to make it too much work to refactor obviously incorrect things.

As soon as we have rough consensus on this and the build robot
are happy I will apply it to GPIO and also pull it into the pinctrl
subsystem.

For me priorities like this:
1) it works after the patch being applied (no regressions);
2) it makes code cleaner at the end;
3) it is presented in logically split parts.

So, as long as 1) and 2) are satisfied I can neglect on 3).

We are in violent agreement :D

What I would like to say is that is up to you after all :-)
For me looks better to split.

-- 
With Best Regards,
Andy Shevchenko