Re: [PATCH] staging:nvec:nvec_ps2.c: Preferingkzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...)
From: Marc Dietrich <hidden>
Date: 2017-02-15 12:07:06
Also in:
lkml
Am Dienstag, 14. Februar 2017, 22:31:20 CET schrieb Arushi Singhal:
Prefer kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...) as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <redacted>
looks like we are in a (make everyone) happy week. Acked-by: Marc Dietrich <redacted>
quoted hunk ↗ jump to hunk
--- drivers/staging/nvec/nvec_ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/nvec/nvec_ps2.cb/drivers/staging/nvec/nvec_ps2.c index 499952c8ef39..3b7bce3ffd19 100644--- a/drivers/staging/nvec/nvec_ps2.c +++ b/drivers/staging/nvec/nvec_ps2.c@@ -107,7 +107,7 @@ static int nvec_mouse_probe(struct platform_device*pdev) struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent); struct serio *ser_dev; - ser_dev = kzalloc(sizeof(struct serio), GFP_KERNEL); + ser_dev = kzalloc(sizeof(*ser_dev), GFP_KERNEL); if (!ser_dev) return -ENOMEM;
Attachments
- signature.asc [application/pgp-signature] 488 bytes