Thread (1 message) 1 message, 1 author, 2015-06-01

Re: [PATCH V2 2/2] pinctrl: tegra-xusb: Fix allocation of pins

From: Linus Walleij <hidden>
Date: 2015-06-01 11:57:35
Also in: linux-gpio

Possibly related (same subject, not in this thread)

On Wed, May 27, 2015 at 3:11 PM, Jon Hunter [off-list ref] wrote:
Commit e5b3b2d9ed20 ("pinctrl: allows not to define the get_group_pins
operation") allows pin controllers not to register the get_group_pins()
function. However, a side-effect of not registering this function is
that pins are not allocated and potentially multiple devices could
attempt to configure the same pins [1]. Although this problem exists in
the pinctrl core, because only a few devices are impacted by this, fix
this for tegra-xusb by adding the get_group_pins() function.

Please note that in addition to adding the get_group_pins() functions
the pins/lanes for the tegra-xusb also need to be registered when
calling pinctrl_register(). This also allows the current pinmux state
to be viewed by the debugfs node "pinmux-pins" for the tegra-xusb pad
controller.

[1] http://www.spinics.net/lists/linux-gpio/msg05810.html

Signed-off-by: Jon Hunter <redacted>
Acked-by: Thierry Reding <redacted>
Patch applied.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help