Re: [PATCH] ARM: tegra: add cpu_disable for hotplug
From: Peter De Schrijver <pdeschrijver@nvidia.com>
Date: 2013-05-22 09:03:04
Also in:
linux-arm-kernel
From: Peter De Schrijver <pdeschrijver@nvidia.com>
Date: 2013-05-22 09:03:04
Also in:
linux-arm-kernel
On Tue, May 21, 2013 at 06:15:48PM +0200, Stephen Warren wrote:
On 05/21/2013 04:13 AM, Joseph Lo wrote:quoted
The Tegra114 could hotplug the CPU0, but the common cpu_disable didn't support that. Adding a Tegra specific cpu_disable function for it. Signed-off-by: Joseph Lo <redacted>quoted
diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.cquoted
+int tegra_cpu_disable(unsigned int cpu) +{ + switch (tegra_chip_id) { + case TEGRA114: + return 0; + default: + return cpu == 0 ? -EPERM : 0; + } +}Do we expect all/most future chips to support hotplug of CPU0? Or at least, fewer chips to have the restriction than not? If so, it might be
Yes. I think we can safely assume future chips will support hotplugging CPU0.
more forward-looking to write that as:
if (tegra_chip_id == TEGRA30)
return cpu == 0 ? -EPERM : 0;Also Tegra20 doesn't support hotplugging CPU0? Cheers, Peter.