Thread (2 messages) 2 messages, 2 authors, 2013-02-20

Re: [RFC PATCH 6/9] hwmon: (lm90) Register to the thermal framework

From: Stephen Warren <hidden>
Date: 2013-02-19 23:18:06
Also in: linux-arm-kernel, linux-devicetree, linux-pm

Possibly related (same subject, not in this thread)

On 02/18/2013 04:30 AM, Wei Ni wrote:
Register the remote sensor to the thermal framework.
It can support to show the temperature and read/write threshold.
 arch/arm/boot/dts/tegra30-cardhu.dtsi |    1 +
 drivers/hwmon/lm90.c                  |  182 ++++++++++++++++++++++++++++++++-
There shouldn't be any need to edit both those files in the same patch.
This patch is making multiple separate logical changes, which should be
separate patches.
quoted hunk
diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
+			#sensor-cells = <1>;
Again, in order to allow that, you need some documentation in
Documentation/devicetree/bindings/. Related to that, you need to Cc the
devicetree maintainers on at least the patches that add that documentation.
quoted hunk
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
quoted hunk
@@ -1576,12 +1728,38 @@ static int lm90_probe(struct i2c_client *client,
...
+	np_args.np = dev->of_node;
+	np_args.index = 0;
As I mentioned before, that'd be better replaced by an explicit of_xlate
function.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help