On 13.12.2012 17:23, Joe Perches wrote:

On Thu, 2012-12-13 at 16:04 +0200, Terje Bergstrom wrote:

quoted

Add support for host1x debugging. Adds debugfs entries, and dumps
channel state to UART in case of stuck job.

trivial note:

[]

quoted

diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h

[]

quoted

+void host1x_debug_output(struct output *o, const char *fmt, ...);

This should be marked __printf(2, 3)
so the compiler verifies format and argument types.

Thanks, I didn't know of this "trick". I'll apply it in the next version.

Considering the amount of feedback I've received from the patches, they
must be top notch quality!

Terje