Re: [PATCH V2 0/6] ARM: tegra: add CPU hotplug support
From: Stephen Warren <hidden>
Date: 2012-08-15 16:05:18
Also in:
linux-arm-kernel
On 08/15/2012 03:22 AM, Joseph Lo wrote:
This patch set adds CPU hotplug support for Tegra20 and Tegra30 SoCs. The first 3 patches make the CPU clock and reset control be a module and the abstraction APIs for TegraXX SoCs. And clean up some codes for later usage. Then add CPU hotplug support for Tegra20 and Tegra30. Verified on Seaboard(Tegra20) and Cardhu(Tegra30) V2: * add one more patch for enable HOTPLUG_CPU [6/6]
The build problem when HOTPLUG_CPU is disabled is still present. The kernel needs to build with this option disabled. Enabling HOTPLUG_CPU in defconfig doesn't force everyone to enable that configuration option; not everyone uses tegra_defconfig, people don't always update to the latest defconfig, people should be free to disable functionality they don't need and still get a buildable & working kernel, etc. Besides, even if defconfig were a legitimate solution to this problem, this series still wouldn't work with "git bisect", since the defconfig patch comes after the patch that causes the build failure.
* move all the SoC specific CPU shutdown code into platform_cpu_die [4/6]
The reboot problem is indeed solved. P.S. It'd be nice to include a summary of what changed in each affected patch, as well as in the cover letter.