Re: [PATCH v3 05/10] resource: add PCI configuration space support
From: Bjorn Helgaas <hidden>
Date: 2012-08-14 05:00:45
Also in:
linux-arm-kernel, linux-devicetree, linux-pci
On Thu, Jul 26, 2012 at 12:55 PM, Thierry Reding [off-list ref] wrote:
quoted hunk
This commit adds a new flag that allows marking resources as PCI configuration space. Signed-off-by: Thierry Reding <redacted> --- Changes in v3: - new patch include/linux/ioport.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/include/linux/ioport.h b/include/linux/ioport.h index 589e0e7..3314843 100644 --- a/include/linux/ioport.h +++ b/include/linux/ioport.h@@ -102,7 +102,7 @@ struct resource { /* PCI control bits. Shares IORESOURCE_BITS with above PCI ROM. */ #define IORESOURCE_PCI_FIXED (1<<4) /* Do not move resource */ - +#define IORESOURCE_PCI_CS (1<<5) /* PCI configuration space */
What is the purpose of this? It seems that you are marking regions that we call MMCONFIG on x86, or ECAM-type regions in the language of the PCIe spec. I see that you set it in several places, but I don't see anything that ever looks for it. Do you have plans to use it in the future? If it really does correspond to MMCONFIG/ECAM, we should handle those regions consistently across all architectures.
/* helpers to define resources */ #define DEFINE_RES_NAMED(_start, _size, _name, _flags) \ -- 1.7.11.2