Re: [PATCH v4 3/3] tegra: add pwm backlight device tree nodes
From: Stephen Warren <hidden>
Date: 2012-08-16 18:45:38
Also in:
linux-devicetree, linux-fbdev, lkml
From: Stephen Warren <hidden>
Date: 2012-08-16 18:45:38
Also in:
linux-devicetree, linux-fbdev, lkml
On 08/16/2012 12:08 AM, Alexandre Courbot wrote:
+++ b/arch/arm/boot/dts/tegra20-ventana.dts
+ backlight_reg: fixedregulator@176 {
+ compatible = "regulator-fixed";
+ regulator-name = "backlight_regulator";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ gpio = <&gpio 176 0>;
+ startup-delay-us = <0>;
+ enable-active-high;
+ regulator-boot-off;
+ };Rather than add that as a separate node at the top-level, I think just add another sub-node to the "regulators" node. Oh, in fact it's already there in next-20120816; you just need to add a label.
+++ b/arch/arm/boot/dts/tegra20.dtsi
- pwm {
+ pwm: pwm {
compatible = "nvidia,tegra20-pwm";
reg = <0x7000a000 0x100>;It's pretty trivial I know, but I'd almost be tempted to make that a separate patch so that it could be cherry-picked somewhere without a tegra20-ventana.dts. But, perhaps that's silly.