On 五, 2012-07-27 at 18:48 +0800, Wei Ni wrote:

On Fri, 2012-07-27 at 15:39 +0800, Zhang Rui wrote:

quoted

On 五, 2012-07-27 at 09:30 +0200, Jean Delvare wrote:

quoted

On Fri, 27 Jul 2012 10:58:21 +0800, Wei Ni wrote:

quoted

On Fri, 2012-07-27 at 09:21 +0800, Zhang Rui wrote:

quoted

is it possible to program the sensor at this time, in your own thermal
driver?

Since we are using the generic thermal driver lm90.c, I'm not sure if we
could program these limits in the generic driver, I think it's better to
have a generic interface to set the limits, so I wish to add a
callback .set_limits() in the generic thermal framework.

I can confirm that hwmon drivers do not set limits, it is up to
user-space to do it if they want. So if there is a need to do so in the
kernel itself, a proper interface at the generic thermal framework
level seems appropriate.

oh, setting limits from userspace?
I think you can program the senor when writing the trip point?
with this patch,
http://marc.info/?l=linux-acpi&m=134318814620429&w=2

Do you mean it can use .set_trip_temp() to set limits when writing the
trip point? But I think this callback is used to change the trip_temp,
it could not used to set the limits, in here the limit value is used to
trigger the interrupt.

yes, you are right. .set_trip_temp does not work.

usually, this is needed to re-program the sensor when the temperature
hits a trip point , right?

can we make use of the thermal_zone_device_ops.notify()?
say we invoke .notify() in thermal_zone_device_update for each trip
point.

thanks,
rui

quoted

thanks,
rui