Thread (63 messages) 63 messages, 11 authors, 2012-08-07

Re: [RFC][PATCH v3 1/3] runtime interpreted power sequences

From: Thierry Reding <hidden>
Date: 2012-07-31 14:22:25
Also in: linux-devicetree, linux-fbdev, lkml

On Tue, Jul 31, 2012 at 03:13:29PM +0100, Mark Brown wrote:
On Tue, Jul 31, 2012 at 12:56:40PM +0200, Thierry Reding wrote:
quoted
On Tue, Jul 31, 2012 at 07:32:20PM +0900, Alex Courbot wrote:
quoted
quoted
The thing is that I am not sure what happens to the platform data
once probe() is done. Isn't it customary to mark it with __devinit
and have it freed after probing is successful?
quoted
No, platform data should stay around forever. Otherwise, consider what
would happen if your driver is built as a module and you unload and load
it again.
__devinit can be discarded if you disable enough kernel features,
HOTPLUG is the main one IIRC, modules might also need to go - drivers
really ought to take a copy of platform data they plan to use at
runtime, though practically speaking you have to try to trigger any
problems.
HOTPLUG is marked EXPERT and explicitly states that it should only be
disabled if you're not using modules or dynamic device discovery. I
think if you've ignored all of that you're no longer entitled to
complain.

Thierry

Attachments

  • (unnamed) [application/pgp-signature] 836 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help