Thread (13 messages) 13 messages, 5 authors, 2012-06-20

Re: [PATCH 2/2] iommu/tegra: gart: Reserve iomem resource

From: Stephen Warren <hidden>
Date: 2012-05-21 16:41:21
Also in: lkml

On 05/21/2012 08:11 AM, Thierry Reding wrote:
* Hiroshi DOYU wrote:
quoted
GART Register/Aperture range should be reserved.
...
quoted
diff --git a/drivers/iommu/tegra-gart.c
b/drivers/iommu/tegra-gart.c
...
quoted
+	if (!devm_request_mem_region(dev, res_remap->start, +
resource_size(res_remap), dev_name(dev))) { +		dev_err(dev,
"failed to reserve GART aperture\n"); +		return -EBUSY; +	} +
I'm not so sure that this is a good idea. If the GART driver
requests the GART aperture, then users of the GART aperture (e.g.
the DRM driver) will no longer be able to use it.
Presumably the DRM driver would be obtaining access to parts of the
GART aperture through the GART driver, rather than just grabbing the
IO region and using it for itself?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help