On Thu, Sep 29, 2011 at 8:27 AM, Peter De Schrijver
[off-list ref] wrote:

On Thu, Sep 29, 2011 at 11:29:51AM +0200, Russell King - ARM Linux wrote:

quoted

On Thu, Sep 29, 2011 at 01:29:35AM +0300, Peter De Schrijver wrote:

quoted

diff --git a/arch/arm/mach-tegra/Makefile b/arch/arm/mach-tegra/Makefile
index f11b910..91a07e1 100644
--- a/arch/arm/mach-tegra/Makefile
+++ b/arch/arm/mach-tegra/Makefile

@@ -31,6 +31,7 @@ obj-${CONFIG_MACH_SEABOARD}             += board-seaboard-pinmux.o

 obj-${CONFIG_MACH_TEGRA_DT}             += board-dt.o
 obj-${CONFIG_MACH_TEGRA_DT}             += board-harmony-pinmux.o
+obj-${CONFIG_MACH_TEGRA_DT}             += board-seaboard-pinmux.o

Since when did Tegra start using braces instead of parens in its Makefile?
I note some of Tegra's makefile is using braces and some of it parens.
What's the reason for this alternative style to the rest of kbuild?

I have no idea. I just followed the style used for the other CONFIG_MACH_TEGRA_DT entries. Colin or Olof, any idea?

From git logs, it looks like the first harmony board file that came
from Colin used braces, and from there it's likely that everyone just
copied and pasted -- I know that's what I did.

Thanks for catching it, Russell, it had obviously completely gone
unnoticed by me and others.

I'll fix up the rest of the file. Peter -- no need to respin, I'll fix
up when I apply.


-Olof