Thread (3 messages) 3 messages, 2 authors, 2011-03-28

Re: [patch 08/29] arm: tegra: Remove unused bogus irq enable/disable magic

STALE5645d REVIEWED: 1 (0M)

From: Colin Cross <hidden>
Date: 2011-03-28 19:00:43
Also in: linux-arm-kernel

1 review trailer.

On Mon, Mar 28, 2011 at 10:12 AM, Thomas Gleixner [off-list ref] wrote:
The core code handles thees already.
thees -> these
quoted hunk ↗ jump to hunk
Signed-off-by: Thomas Gleixner <redacted>
Cc: Colin Cross <redacted>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
---
 arch/arm/mach-tegra/gpio.c |   19 -------------------
 1 file changed, 19 deletions(-)

Index: linux-2.6-tip/arch/arm/mach-tegra/gpio.c
===================================================================
--- linux-2.6-tip.orig/arch/arm/mach-tegra/gpio.c
+++ linux-2.6-tip/arch/arm/mach-tegra/gpio.c
@@ -275,13 +275,6 @@ void tegra_gpio_resume(void)
       }

       local_irq_restore(flags);
-
-       for (i = INT_GPIO_BASE; i < (INT_GPIO_BASE + TEGRA_NR_GPIOS); i++) {
-               struct irq_desc *desc = irq_to_desc(i);
-               if (!desc || (desc->status & IRQ_WAKEUP))
-                       continue;
-               enable_irq(i);
-       }
 }

 void tegra_gpio_suspend(void)
@@ -289,18 +282,6 @@ void tegra_gpio_suspend(void)
       unsigned long flags;
       int b, p, i;

-       for (i = INT_GPIO_BASE; i < (INT_GPIO_BASE + TEGRA_NR_GPIOS); i++) {
-               struct irq_desc *desc = irq_to_desc(i);
-               if (!desc)
-                       continue;
-               if (desc->status & IRQ_WAKEUP) {
-                       int gpio = i - INT_GPIO_BASE;
-                       pr_debug("gpio %d.%d is wakeup\n", gpio/8, gpio&7);
-                       continue;
-               }
-               disable_irq(i);
-       }
-
       local_irq_save(flags);
       for (b = 0; b < ARRAY_SIZE(tegra_gpio_banks); b++) {
               struct tegra_gpio_bank *bank = &tegra_gpio_banks[b];

This will cause warnings in both the suspend and resume functions as i
is now unused.

Other than that:
Acked-by: Colin Cross <redacted>

Do you want me to take this through the Tegra tree for 2.6.39-rc1?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help