Thread (4 messages) 4 messages, 2 authors, 2026-09-09

Re: [PATCH] staging: rtl8723bs: fix unnecessary else block with only a break statement

flat view

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2026-09-09 09:34:02
Also in: lkml

On Wed, Sep 09, 2026 at 02:29:38PM +0600, Isaac Aneek Sarker wrote:
quoted hunk ↗ jump to hunk
Warning found by checkpatch.pl : else is not generally useful after a
break or return. The function would reach the break statement after
if-elseif block even if the else block is not used.

Signed-off-by: Isaac Aneek Sarker <redacted>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 3c82012fdc6c..a203ef8bd6f6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1789,8 +1789,8 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
 			/* Duplicate entry is found!! Do not insert current entry. */
 			/* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
 			return false;
-		else
-			break;
+
+		break;
Did you test this code?  It looks like you now just changed the logic a
lot, right?

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help