Re: [PATCH 3/3] staging: r8188eu: Remove redundant 'if' statement
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-10-18 14:42:55
Also in:
lkml
On Sun, Oct 17, 2021 at 04:28:12PM +0200, Fabio M. De Francesco wrote:
Remove a redundant 'if' statement. Acked-by: Martin Kaiser <redacted> Acked-by: Phillip Potter <phil@philpotter.co.uk> Signed-off-by: Fabio M. De Francesco <redacted> --- drivers/staging/r8188eu/core/rtw_cmd.c | 6 ------ 1 file changed, 6 deletions(-)
Why is there not a "v2" in the subject line like the other patches in this series?
quoted hunk ↗ jump to hunk
diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c index 6fb79d711692..42084b029473 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c@@ -254,12 +254,6 @@ int rtw_cmd_thread(void *context) while (1) { wait_for_completion(&pcmdpriv->enqueue_cmd); - if (padapter->bDriverStopped || - padapter->bSurpriseRemoved) { - DBG_88E("%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n", - __func__, padapter->bDriverStopped, padapter->bSurpriseRemoved, __LINE__); - break; - }
Why is this redundant? It is not obvious from the diff what is going on so you should say a bit more in the changelog text please. thanks, greg k-h