Re: [PATCH v3] staging: rtl8723bs: os_dep: simplify the return statement
From: Dan Carpenter <hidden>
Date: 2021-10-14 14:59:28
Also in:
lkml
On Thu, Oct 14, 2021 at 08:10:00PM +0530, Saurav Girepunje wrote:
quoted hunk ↗ jump to hunk
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 29 ++++++++----------- 1 file changed, 12 insertions(+), 17 deletions(-)diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 0868f56e2979..217b86bfb722 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c@@ -2281,19 +2281,16 @@ static int rtw_cfg80211_add_monitor_if(struct adapter *padapter, char *name, str struct rtw_wdev_priv *pwdev_priv = adapter_wdev_data(padapter); if (!name) { - ret = -EINVAL; - goto out; + return -EINVAL; }
You need to delete the curly braces, otherwise your patch will introduce a checkpatch warning. Same below as well. regards, dan carpenter