Re: [PATCH v2 04/10] staging: media: zoran: add debugfs
From: Dan Carpenter <hidden>
Date: 2021-10-14 07:38:38
Also in:
linux-media, lkml
On Wed, Oct 13, 2021 at 06:58:06PM +0000, Corentin Labbe wrote:
+config VIDEO_ZORAN_DEBUG + bool "Enable zoran debugfs" + depends on VIDEO_ZORAN + depends on DEBUG_FS + help + Say y to enable zoran debug file. + This will create /sys/kernel/debug/CARD_NAME/debug for displaying + stats and debug information.
Why bother with a CONFIG? Just make it always on?
quoted hunk ↗ jump to hunk
@@ -1286,6 +1321,12 @@ static int zoran_probe(struct pci_dev *pdev, const struct pci_device_id *ent) zr->map_mode = ZORAN_MAP_MODE_RAW; +#ifdef CONFIG_VIDEO_ZORAN_DEBUG + zr->dbgfs_dir = debugfs_create_dir(ZR_DEVNAME(zr), NULL); + debugfs_create_file("debug", 0444, + zr->dbgfs_dir, zr, + &zoran_debugfs_fops);
This whitespace is weird. regards, dan carpenter