Re: [PATCH 6/9] staging: r8188eu: HardwareType is write-only
From: Michael Straube <hidden>
Date: 2021-10-05 22:07:02
Also in:
lkml
On 10/5/21 22:08, Martin Kaiser wrote:
quoted hunk ↗ jump to hunk
HardwareType in struct adapter is never read, it can be removed. Signed-off-by: Martin Kaiser <redacted> --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 1 - drivers/staging/r8188eu/include/drv_types.h | 1 - drivers/staging/r8188eu/include/hal_intf.h | 2 -- 3 files changed, 4 deletions(-)diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index c15a75513c8c..9544300fab65 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c@@ -562,6 +562,5 @@ void rtl8188eu_xmit_tasklet(unsigned long priv) void rtl8188eu_set_hw_type(struct adapter *adapt) { adapt->chip_type = RTL8188E; - adapt->HardwareType = HARDWARE_TYPE_RTL8188EU; DBG_88E("CHIP TYPE: RTL8188E\n"); }diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/r8188eu/include/drv_types.h index 6d63429d06c6..9fa561ad340b 100644 --- a/drivers/staging/r8188eu/include/drv_types.h +++ b/drivers/staging/r8188eu/include/drv_types.h@@ -206,7 +206,6 @@ struct adapter { int pid[3];/* process id from UI, 0:wps, 1:hostapd, 2:dhcpcd */ int bDongle;/* build-in module or external dongle */ u16 chip_type; - u16 HardwareType; u16 interface_type;/* USB,SDIO,SPI,PCI */ struct dvobj_priv *dvobj;diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h index 29ca90a86844..ee8e67dafe7c 100644 --- a/drivers/staging/r8188eu/include/hal_intf.h +++ b/drivers/staging/r8188eu/include/hal_intf.h@@ -137,8 +137,6 @@ struct hal_ops { #define RF_CHANGE_BY_HW BIT(30) #define RF_CHANGE_BY_SW BIT(31) -#define HARDWARE_TYPE_RTL8188EU 17 - #define is_boot_from_eeprom(adapter) (adapter->eeprompriv.EepromOrEfuse) void rtl8188eu_set_hal_ops(struct adapter *padapter);
Looks good to me. Acked-by: Michael Straube <redacted> Thanks, Michael