[PATCH v9 03/16] staging: r8188eu: remove unnecessary test in usbctrl_vendorreq()
From: Fabio M. De Francesco <hidden>
Date: 2021-09-21 18:19:19
Also in:
lkml
Subsystem:
staging subsystem, the rest · Maintainers:
Greg Kroah-Hartman, Linus Torvalds
Remove unnecessary test for "!io_buf" in usbctrl_vendorreq(). This test is not necessary because io_buf has been assigned with the address of a region of dinamically allocated memory (dvobj->usb_alloc_vendor_req_buf) by rtw_init_intf_priv() in os_dep/usb_intf.c. Co-developed-by: Pavel Skripkin <redacted> Signed-off-by: Pavel Skripkin <redacted> Signed-off-by: Fabio M. De Francesco <redacted> --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c
index 84ec7c1346b1..61a016e3608f 100644
--- a/drivers/staging/r8188eu/hal/usb_ops_linux.c
+++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c@@ -34,12 +34,6 @@ static int usbctrl_vendorreq(struct intf_hdl *intf, u16 value, void *data, u16 l /* Acquire IO memory for vendorreq */ io_buf = dvobjpriv->usb_vendor_req_buf; - if (!io_buf) { - DBG_88E("[%s] io_buf == NULL\n", __func__); - status = -ENOMEM; - goto release_mutex; - } - if (requesttype == REALTEK_USB_VENQT_READ) pipe = usb_rcvctrlpipe(udev, 0);/* read_in */ else
@@ -91,7 +85,7 @@ static int usbctrl_vendorreq(struct intf_hdl *intf, u16 value, void *data, u16 l if ((value >= FW_8188E_START_ADDRESS && value <= FW_8188E_END_ADDRESS) || status == len) break; } -release_mutex: + mutex_unlock(&dvobjpriv->usb_vendor_req_mutex); exit: return status;
--
2.33.0