Thread (31 messages) 31 messages, 4 authors, 2021-09-14

Re: [PATCH v4 15/18] staging: r8188eu: hal: Clean up usbctrl_vendorreq()

From: Fabio M. De Francesco <hidden>
Date: 2021-09-14 13:24:13
Also in: lkml

On Tuesday, September 14, 2021 11:24:05 AM CEST Dan Carpenter wrote:
I don't understand why you moved these from the top to the bottom.
But the original was better.  In networking code declarations are
normally written in Reverse Christmas Tree format, longest to shortest,
like this:

	long long long_name;
	medium name;
	u8 short;
Dear Dan,

I'm sorry that I forgot to thank you for the reviews in the other messages I 
sent in reply. :(

I also forgot to answer to the above question...

I changed the order of the declarations because David Laight wrote "I think 
you'll need 'reverse xmas tree' ordering as well." (copy-paste from his 
message).

As far as I know you are both experienced kernel developers, so I took his 
words for truth. Is it a matter of personal taste or Reverse/Non Reverse Xmas 
Trees are strictly required by the Linux kernel coding style guidelines?

I thank you very much for the time you spent for reviewing.

Regards,

Fabio 

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help