Re: [PATCH 02/14] staging: r8188eu: remove hal_reset_security_engine from struct hal_ops

On Mon, 6 Sept 2021 at 09:26, Dan Carpenter [off-list ref] wrote:

On Mon, Sep 06, 2021 at 02:00:54AM +0100, Phillip Potter wrote:

quoted

Remove hal_reset_security_engine function pointer from struct hal_ops,
as it is unused.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
---
 drivers/staging/r8188eu/include/hal_intf.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h
index 5612274dea4d..3cbe6c277677 100644
--- a/drivers/staging/r8188eu/include/hal_intf.h
+++ b/drivers/staging/r8188eu/include/hal_intf.h

@@ -250,7 +250,6 @@ struct hal_ops {
                                u32 bndy_cnt);

      void (*hal_notch_filter)(struct adapter *adapter, bool enable);
-     void (*hal_reset_security_engine)(struct adapter *adapter);
      c2h_id_filter c2h_id_filter_ccx;
 };

I love these patchsets which are removing the HAL layer, but it would
be better if you folded patches 1 and 2 together because it would be
easier to review.  That way we can just say "Well, if this patch isn't
correct it will cause a compile error so let's assume it's correct
unless the kbuild-bot complains."

There are other pairs in this patchset which are the same way where they
would be easier to review if they were merged. 3 & 4.  5 & 6.  Etc.

The patcheset is fine but for future reference please fold them together.

Reviewed-by: Dan Carpenter <redacted>

regards,
dan carpenter

Dear Dan,

Thank you for the review, much appreciated. I will endeavour to do
this in future.

Regards,
Phil