On Saturday, September 4, 2021 7:09:58 PM CEST kernel test robot wrote:

Hi "Fabio,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Fabio-M-De-Francesco/

staging-r8188eu-Shorten-and-simplify-calls-chain/20210904-231010

base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 

fde4862d1ac7100028da4371d92454fec6cf3f4f

[...]

All errors (new ones prefixed by >>):

   drivers/staging/r8188eu/hal/usb_ops_linux.c: In function 'usb_write':

quoted

quoted

drivers/staging/r8188eu/hal/usb_ops_linux.c:105:47: error: 

'REALTEK_USB_VENQT_SEND' undeclared (first use in this function); did you 
mean 'REALTEK_USB_VENQT_READ'?

     105 |                                               

REALTEK_USB_VENQT_SEND, value,

         |                                               

^~~~~~~~~~~~~~~~~~~~~~

Hello to all,

I apologize for this easily avoidable mistake. I'm about to post the v2 
series.

However, I write this message to affirm that Pavel's tests on this patch are 
still valid and confirmed because his copy *has* the right parameter that is 
REALTEK_USB_VENQT_WRITE.

It's all my fault. Pavel warned me that during the review and test he noticed 
that I had written REALTEK_USB_VENQT_READ and obviously my build was 
successful because it was a symbol known to the compiler.

Pavel successfully changed his local copy and I (independently) changed mine 
without thinking about rebuilding. I was absolutely certain it was the 
expected parameter (perhaps the function name - usb_control_msg_send () - 
played a part in leading me to this stupid mistake).

In summary, first I want to apologize for the noise, secondly I want to 
apologize to Pavel who is co-author and tester of this 3/3 of our series.

Regards,

Fabio