Re: [PATCH 1/3] staging: rtl8723bs: remove possible deadlock when disconnect (v2)
From: Fabio Aiuto <hidden>
Date: 2021-09-20 17:49:18
Also in:
linux-wireless
From: Fabio Aiuto <hidden>
Date: 2021-09-20 17:49:18
Also in:
linux-wireless
Hi Hans, On Mon, Sep 20, 2021 at 04:55:00PM +0200, Hans de Goede wrote:
From: Fabio Aiuto <redacted>
when turning off a connection, lockdep complains with the
following warning (a modprobe has been done but the same
happens with a disconnection from NetworkManager,
it's enough to trigger a cfg80211_disconnect call):
[ 682.855867] ======================================================
[ 682.855877] WARNING: possible circular locking dependency detected
[ 682.855887] 5.14.0-rc6+ #16 Tainted: G C OE
[ 682.855898] ------------------------------------------------------
[ 682.855906] modprobe/1770 is trying to acquire lock:
[ 682.855916] ffffb6d000332b00 (&pxmitpriv->lock){+.-.}-{2:2},
at: rtw_free_stainfo+0x52/0x4a0 [r8723bs]
[ 682.856073]
but task is already holding lock:
[ 682.856081] ffffb6d0003336a8 (&pstapriv->sta_hash_lock){+.-.}-{2:2},
at: rtw_free_assoc_resources+0x48/0x110 [r8723bs]
[ 682.856207]
which lock already depends on the new lock.
[ 682.856215]
the existing dependency chain (in reverse order) is:<snip> thank you for working on this, at a first look the patch series looks good. I will test it tomorrow. Thank you, fabio