Thread (4 messages) 4 messages, 3 authors, 2021-09-20

Re: [PATCH] staging: vt6656: Fix warning message generated by checkpatch.pl

From: Dan Carpenter <hidden>
Date: 2021-09-16 14:06:18

On Wed, Sep 15, 2021 at 01:57:39PM -0500, Joshua de Block wrote:
quoted hunk ↗ jump to hunk
Description: Address the following checkpatch warning:
   * WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by: Joshua de Block <redacted>
---
 drivers/staging/vt6656/rxtx.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index a31947f2620d..b129397ef41f 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -58,7 +58,6 @@ static struct vnt_usb_send_context
 	struct vnt_usb_send_context *context = NULL;
 	int ii;
 
-	dev_dbg(&priv->usb->dev, "%s\n", __func__);
 
Delete the next blank line as well.  Otherwise it introduces a new
checkpatch warning.
 	for (ii = 0; ii < priv->num_tx_context; ii++) {
 		if (!priv->tx_context[ii])
regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help