Thread (19 messages) 19 messages, 4 authors, 2021-09-01

Re: [PATCH v4] staging: greybus: Convert uart.c from IDR to XArray

From: Matthew Wilcox <willy@infradead.org>
Date: 2021-08-30 12:17:23
Also in: lkml

On Mon, Aug 30, 2021 at 01:52:48PM +0200, Johan Hovold wrote:
Whether the API is better is debatable. As I said, almost no drivers use
the new XArray interface, and perhaps partly because the new interface
isn't as intuitive as has been claimed (e.g. xa_load() instead of
ida_find()). And IDR/IDA isn't marked/documented as deprecated as far as
I know.
I can't just slap a 'deprecated' attribute on it.  That'll cause a
storm of warnings.  What would you suggest I do to warn people that
this interface is deprecated and I would like to remove it?

Why do you think that idr_find() is more intuitive than xa_load()?
The 'find' verb means that you search for something.  But it doesn't
search for anything; it just returns the pointer at that index.
'find' should return the next non-NULL pointer at-or-above a given
index.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help