Re: [PATCH v4] staging: r8188eu: core: remove null check before vfree
From: Kari Argillander <hidden>
Date: 2021-08-29 17:13:58
Also in:
lkml
On Sun, Aug 29, 2021 at 10:30:09PM +0530, Saurav Girepunje wrote:
Remove NULL check. NULL check before freeing function is not needed. Correct the indentation. Signed-off-by: Saurav Girepunje <redacted> --- ChangeLog V4: - Add Change log below --- line ChangeLog V3: - Add change log. ChangeLog V2: - Correct the indentation.
You need "---" here also. So everything what is between --- here --- will be ignored when you apply patch. This is good place to write changelog, if you have tested this with real hardware, if you have any guestions about your own implementation etc.
quoted hunk ↗ jump to hunk
drivers/staging/r8188eu/core/rtw_sta_mgt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c b/drivers/staging/r8188eu/core/rtw_sta_mgt.c index f6dffed53a60..c3600cb1790a 100644 --- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c +++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c@@ -155,9 +155,8 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv) spin_unlock_bh(&pstapriv->sta_hash_lock); /*===============================*/ - if (pstapriv->pallocated_stainfo_buf) - vfree(pstapriv->pallocated_stainfo_buf); - } + vfree(pstapriv->pallocated_stainfo_buf); + } return _SUCCESS; } --2.32.0