On Sat, Aug 28, 2021 at 11:46 AM Greg KH [off-list ref] wrote:

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Now I get it. I've never used this style of email ever before so am a
novice. Forgive me. Also I didn't get what you mean should I include
quotations after my reply?

On Sat, Aug 28, 2021 at 11:37:50AM +0200, Krish Jain wrote:

quoted

Hi. Thanks for your response. Changing to  "const static" would fix
the first error but looking at the second error indicates that it
can't be a const, right? So checkpatch.pl was wrong?

checkpatch.pl is a perl script that does its best here.  You always have
to then look at the code itself to see if what it is asking you to do is
correct.

And you always have to at the very least, test build your changes to
verify that they do not break anything.

thanks,

greg k-h

Thank you so much. I didn't realize that I could have tested it by
just building the driver and not the entire kernel. Anyway, I'd still
love to learn more and contribute to the kernel. Where can I find
"small fixes" I can make?


Warm Regards,

Krish