Thread (6 messages) 6 messages, 5 authors, 2021-08-28

Re: [PATCH v3] staging: r8188eu: Provide a TODO file for this driver

From: Pavel Skripkin <hidden>
Date: 2021-08-27 15:39:12
Also in: lkml

On 8/27/21 1:08 PM, Fabio M. De Francesco wrote:
quoted hunk ↗ jump to hunk
Provide a TODO file that lists the tasks that should be carried out in
order to move this driver off drivers/staging.

Signed-off-by: Fabio M. De Francesco <redacted>
---

v2->v3: Added a task suggested by Dan Carpenter
[off-list ref].
v1->v2: According to reviews by Fabio Aiuto [off-list ref] and Greg K-H
         [off-list ref], remove "[] is currently in development...",
         indent and properly wrap the lines, remove the unnecessary last paragraph.

  drivers/staging/r8188eu/TODO | 13 +++++++++++++
  1 file changed, 13 insertions(+)
  create mode 100644 drivers/staging/r8188eu/TODO
diff --git a/drivers/staging/r8188eu/TODO b/drivers/staging/r8188eu/TODO
new file mode 100644
index 000000000000..98f918480990
--- /dev/null
+++ b/drivers/staging/r8188eu/TODO
@@ -0,0 +1,13 @@
+To-do list:
+
+* Correct the coding style according to Linux guidelines; please read the document
+  at https://www.kernel.org/doc/html/latest/process/coding-style.html.
+* Remove unnecessary debugging/printing macros; for those that are still needed
+  use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
+* Remove dead code such as unusued functions, variables, fields, etc..
+* Use in-kernel API and remove unnecessary wrappers where possible.
+* Fix bugs due to code that sleeps in atomic context.
+* Remove the HAL layer and migrate its functionality into the relevant parts of
+  the driver.
+* Switch to use LIB80211.
+* Switch to use MAC80211.
I think, we can add an entry about error handling. There are _a lot_ 
function calls without proper error handling. rtw_read*() calls are on 
me, but others...




With regards,
Pavel Skripkin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help