Thread (3 messages) 3 messages, 2 authors, 2021-08-26

Re: [PATCH v2 3/5] treewide: Replace 0-element memcpy() destinations with flexible arrays

From: Keith Packard <keithp@keithp.com>
Date: 2021-08-26 05:24:29
Also in: linux-hardening, linux-scsi, linux-wireless, lkml, netdev

Kees Cook [off-list ref] writes:
In some cases, use of the flex_array() helper is needed when a flexible
array is part of a union.
The code below seems to show that the helper is also needed when the
flexible array is the only member of a struct? Or is this just an
extension of the 'part of a union' clause?
quoted hunk ↗ jump to hunk
@@ -160,7 +160,7 @@ struct bmi_cmd {
 
 union bmi_resp {
 	struct {
-		u8 payload[0];
+		DECLARE_FLEX_ARRAY(u8, payload);
 	} read_mem;
 	struct {
 		__le32 result;
-- 
-keith

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help