Re: [PATCH linux-next] r8188eu: remove unneeded conversions to bool
From: Pavel Skripkin <hidden>
Date: 2021-08-24 08:00:57
Also in:
lkml
On 8/24/21 9:34 AM, CGEL wrote:
From: Jing Yangyang <redacted> Found with scripts/coccinelle/misc/boolconv.cocci. Reported-by: Zeal Robot <redacted> Signed-off-by: Jing Yangyang <redacted>
Reviewed-by: Pavel Skripkin <redacted>
quoted hunk ↗ jump to hunk
--- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 5325fe4..20dc4d4 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c@@ -3758,7 +3758,7 @@ int issue_probereq_p2p_ex(struct adapter *adapter, u8 *da, int try_cnt, int wait u32 start = jiffies; do { - ret = _issue_probereq_p2p(adapter, da, wait_ms > 0 ? true : false); + ret = _issue_probereq_p2p(adapter, da, wait_ms > 0); i++;@@ -4890,7 +4890,7 @@ int issue_probereq_ex(struct adapter *padapter, struct ndis_802_11_ssid *pssid, u32 start = jiffies; do { - ret = _issue_probereq(padapter, pssid, da, wait_ms > 0 ? true : false); + ret = _issue_probereq(padapter, pssid, da, wait_ms > 0); i++;@@ -5605,7 +5605,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow da = get_my_bssid(&pmlmeinfo->network); do { - ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0 ? true : false); + ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0); i++;@@ -5728,7 +5728,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int da = get_my_bssid(&pmlmeinfo->network); do { - ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0 ? true : false); + ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0); i++;@@ -5839,7 +5839,7 @@ int issue_deauth_ex(struct adapter *padapter, u8 *da, unsigned short reason, int u32 start = jiffies; do { - ret = _issue_deauth(padapter, da, reason, wait_ms > 0 ? true : false); + ret = _issue_deauth(padapter, da, reason, wait_ms > 0); i++;