Thread (7 messages) 7 messages, 4 authors, 2021-08-23

Re: [PATCH] staging: r8188eu: make rtw_deinit_intf_priv return void

From: Phillip Potter <phil@philpotter.co.uk>
Date: 2021-08-23 21:20:49
Also in: lkml

On Mon, 23 Aug 2021 at 19:41, Pavel Skripkin [off-list ref] wrote:
quoted hunk ↗ jump to hunk
rtw_deinit_intf_priv() always return success, so there is no need in
return value

Signed-off-by: Pavel Skripkin <redacted>
---
 drivers/staging/r8188eu/os_dep/usb_intf.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
index e002070f7fba..37694aa96d13 100644
--- a/drivers/staging/r8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
@@ -129,13 +129,10 @@ static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
        return rst;
 }

-static u8 rtw_deinit_intf_priv(struct dvobj_priv *dvobj)
+static void rtw_deinit_intf_priv(struct dvobj_priv *dvobj)
 {
-       u8 rst = _SUCCESS;
-
        kfree(dvobj->usb_alloc_vendor_req_buf);
        _rtw_mutex_free(&dvobj->usb_vendor_req_mutex);
-       return rst;
 }

 static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
--
2.32.0
Dear Pavel,

Looks good - going to test your RFC series now btw.

Acked-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help