Thread (8 messages) 8 messages, 3 authors, 2021-08-24

Re: [PATCH RFC] staging: r8188eu: Use usb_control_msg_recv/send() in usbctrl_vendorreq()

From: Fabio M. De Francesco <hidden>
Date: 2021-08-23 10:52:09
Also in: lkml

On Monday, August 23, 2021 10:30:53 AM CEST Pavel Skripkin wrote:
On 8/23/21 11:11 AM, Pavel Skripkin wrote:
quoted
On 8/23/21 2:02 AM, Fabio M. De Francesco wrote:
quoted
Replace usb_control_msg() with the new usb_control_msg_recv() and
usb_control_msg_send() API of USB Core.
[...]
@@ -47,19 +47,20 @@ static int usbctrl_vendorreq(struct intf_hdl *pintfhdl, u16 value, void *pdata,
  		memset(pIo_buf, 0, len);
  
		^^^^^^^^^^^^^^^^^^^^^^^

And this memset becomes useless, since usb_control_msg_recv cannot 
receive only part of the message
I didn't notice it at all. Obviously, I'll remove it.

Thanks,

Fabio
With regards,
Pavel Skripkin


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help