On Thu, Aug 19, 2021 at 08:24:11PM +0300, Andy Shevchenko wrote:

On Fri, Aug 13, 2021 at 7:39 PM Kees Cook [off-list ref] wrote:

quoted

On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote:

quoted

From: Arnd Bergmann <arnd@arndb.de>

The input_system_configure_channel_sensor() function lost its final
return code in a previous patch:

drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor':
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]

Restore what was there originally.

Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I hit this too. Thanks!

Reviewed-by: Kees Cook <redacted>

Me too,
Tested-by: Andy Shevchenko <redacted>
Reviewed-by: Andy Shevchenko <redacted>

Mauro, are you able to get this into your tree, please? Or Greg? It's in
staging. :) This is breaking the build.

-- 
Kees Cook