Thread (2 messages) 2 messages, 2 authors, 2021-08-19

Re: [PATCH v2 45/63] ath11k: Use memset_startat() for clearing queue descriptors

From: Kees Cook <hidden>
Date: 2021-08-19 16:25:14
Also in: ath11k, dri-devel, linux-block, linux-hardening, linux-kbuild, linux-wireless, lkml, netdev

Possibly related (same subject, not in this thread)

On Thu, Aug 19, 2021 at 04:19:37PM +0300, Kalle Valo wrote:
Kees Cook [off-list ref] writes:
quoted
In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memset(), avoid intentionally writing across
neighboring fields.

Use memset_startat() so memset() doesn't get confused about writing
beyond the destination member that is intended to be the starting point
of zeroing through the end of the struct. Additionally split up a later
field-spanning memset() so that memset() can reason about the size.

Cc: Kalle Valo <redacted>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <redacted>
To avoid conflicts I prefer taking this via my ath tree.
The memset helpers are introduced as part of this series, so that makes
things more difficult. Do you want me to create a branch with the
helpers that you can merge?

-Kees

-- 
Kees Cook
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help