Re: [PATCH v2] media: atomisp: Fix error handling in probe

On Tue, Aug 10, 2021 at 07:29:43PM +0300, Evgeny Novikov wrote:

There were several issues with handling errors in lm3554_probe():
- Probe did not set the error code when v4l2_ctrl_handler_init() failed.
- It intermixed gotos for handling errors of v4l2_ctrl_handler_init()
  and media_entity_pads_init().
- It did not set the error code for failures of v4l2_ctrl_new_custom().
- Probe did not free resources in case of failures of
  atomisp_register_i2c_module().

The patch fixes all these issues.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <redacted>

Perfect.  Thanks!

Reviewed-by: Dan Carpenter <redacted>

regards,
dan carpenter