Re: [PATCH] Declare the file_operations struct as const
From: Fabio M. De Francesco <hidden>
Date: 2021-08-27 06:49:34
On Friday, August 27, 2021 3:59:28 AM CEST Krish Jain wrote:
quoted hunk ↗ jump to hunk
From: Krish Jain [off-list ref] Declare the file_operations struct as const as done elsewhere in the kernel, as there are no modifications to its fields. Signed-off-by: Krish Jain <redacted> --- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index ddbde3f8430e..ec18f2ddd66c 100644 --- a/drivers/staging/android/ashmem.c +++ b/drivers/staging/android/ashmem.c@@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file,unsigned long addr, static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) { - static struct file_operations vmfile_fops; + const static struct file_operations vmfile_fops; struct ashmem_area *asma = file->private_data; int ret = 0; -- 2.25.1
Are you sure that it works? I wouldn't be. You didn't build this file. Please build your changes before submitting patches. Furthermore, please always rebase to the current version of the staging tree. Finally, please use the class modifier "static" as the first keyword of a declaration/definition as it is done everywhere in the kernel (see "grep -rn "static const" drivers/staging/" and then switch to "const static" and read the output). Thanks, Fabio