On Mon, Jul 26, 2021 at 11:11:48AM +0300, Dan Carpenter wrote:

On Fri, Jul 23, 2021 at 05:15:10PM +0200, Len Baker wrote:

quoted

Hi,

On Wed, Jul 21, 2021 at 11:06:24AM +0300, Dan Carpenter wrote:

quoted

On Mon, Jul 19, 2021 at 03:24:38PM +0000, David Laight wrote:

quoted

I know only root can set module parameters, but having one
that contains a string used as a printf format seems
dangerous at best.

Isn't it best to let userspace rename the interfaces later on?

Yeah.  I think you're right.

Sorry, but I don't understand if the code needs to be improved or not.
Is the code shown by Dan not correct?

We should remove the ifname[] array and the module option completely.

Thanks for the clarification.

Regards,
Len