Hi Dan,

On Sat, Jul 17, 2021 at 11:29:01AM +0300, Dan Carpenter wrote:

On Wed, Jul 14, 2021 at 09:04:57PM +0200, Fabio Aiuto wrote:

quoted

Hello Dan,

On Wed, Jul 14, 2021 at 06:26:05PM +0300, Dan Carpenter wrote:

quoted

On Wed, Jul 14, 2021 at 05:11:14PM +0200, Fabio Aiuto wrote:

quoted

fix following post commit hook checkpatch issue:

CHECK: Avoid CamelCase: <NetType>
45: FILE: drivers/staging/rtl8723bs/include/ieee80211.h:170:
+#define is_supported_ht(NetType) (((NetType)
	& (WIRELESS_11_24N)) ? true : false)

Signed-off-by: Fabio Aiuto <redacted>
---
 drivers/staging/rtl8723bs/include/ieee80211.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index 8eb0557a077a..b2c1a7dafcee 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h

@@ -167,7 +167,7 @@ enum network_type {
 
 #define IsSupportedTxCCK(NetType) (((NetType) & (WIRELESS_11B)) ? true : false)
 #define IsSupportedTxOFDM(NetType) (((NetType) & (WIRELESS_11G) ? true : false)

These are the same.

quoted

-#define is_supported_ht(NetType) (((NetType) & (WIRELESS_11_24N)) ? true : false)
+#define is_supported_ht(net_type) (((net_type) & (WIRELESS_11_24N)) ? true : false)
 

NetType -> net_type, or did you mean something else?

Yes.  If you're going to change it then change the surrounding code as
well.

regards,
dan carpenter

ok, will add a patch in next v2,

thank you,

fabio