Thread (19 messages) 19 messages, 3 authors, 2021-07-27

Re: [PATCH 01/15] staging: vt6655: remove filename from baseband.h

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-07-27 13:22:38

On Fri, Jul 23, 2021 at 04:13:35PM +0100, Lee Jones wrote:
On Fri, 23 Jul 2021, Lucas Henneman wrote:
quoted
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for baseband.h.
I would paste the exact warning you get from checkpatch.pl, warts
(line numbers) and all on a completely separate line.
quoted
Signed-off-by: Lucas Henneman <redacted>
---
 drivers/staging/vt6655/baseband.h | 2 --
 1 file changed, 2 deletions(-)
Nice first attempt at working with Mainline Lucas.

The premise of the patches seem okay.  I don't personally allow
filenames into new commits in subsystems I maintain.

Seeing as though these patches are *so* trivial, if I were Greg, I'd
be asking you to bundle each of these changes into a single patch.
I'll take these as-is, it's fine.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help