Thread (2 messages) 2 messages, 2 authors, 2021-06-23

Re: [PATCH] staging: rtl8723bs: convert function to static

From: Hans de Goede <hidden>
Date: 2021-06-23 13:08:42
Also in: lkml

Hi,

On 6/23/21 3:01 PM, Fabio Aiuto wrote:
function chk_sta_is_alive() is used only inside core/rtw_ap.c
so remove the prototype and convert it to static.

Signed-off-by: Fabio Aiuto <redacted>
Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <redacted>

Regards,

Hans
quoted hunk ↗ jump to hunk
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 23bbdf084631..3e2d8b735fc8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -164,8 +164,7 @@ static void update_BCNTIM(struct adapter *padapter)
 	pnetwork_mlmeext->IELength = offset + remainder_ielen;
 }
 
-u8 chk_sta_is_alive(struct sta_info *psta);
-u8 chk_sta_is_alive(struct sta_info *psta)
+static u8 chk_sta_is_alive(struct sta_info *psta)
 {
 	sta_update_last_rx_pkts(psta);
 
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help