Re: [RFC 16/19] staging: qlge: remove deadcode in qlge_build_rx_skb
From: Dan Carpenter <hidden>
Date: 2021-06-22 07:30:02
Also in:
lkml, netdev
From: Dan Carpenter <hidden>
Date: 2021-06-22 07:30:02
Also in:
lkml, netdev
On Mon, Jun 21, 2021 at 09:48:59PM +0800, Coiby Xu wrote:
This part of code is for the case that "the headers and data are in a single large buffer". However, qlge_process_mac_split_rx_intr is for handling packets that packets underwent head splitting. In reality, with jumbo frame enabled, the part of code couldn't be reached regardless of the packet size when ping the NIC.
This commit message is a bit confusing. We're just deleting the else statement. Once I knew that then it was easy enough to review qlge_process_mac_rx_intr() and see that if if ib_mac_rsp->flags3 & IB_MAC_IOCB_RSP_DL is set then ib_mac_rsp->flags4 & IB_MAC_IOCB_RSP_HV must be set. regards, dan carpenter