Re: [PATCH] staging: rtl8188eu: convert DBG_88E calls in core/rtw_sta_mgt.c
From: Joe Perches <joe@perches.com>
Date: 2021-06-13 01:10:51
Also in:
lkml
On Sun, 2021-06-13 at 00:28 +0100, Phillip Potter wrote:
Convert both calls to the DBG_88E macro in core/rtw_sta_mgt.c into netdev_dbg calls. The DBG_88E macro is unnecessary, as visibility of debug messages can be controlled more precisely by just using debugfs. It is important to keep these messages still, as they are displayable via a kernel module parameter when using DBG_88E.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
[]
quoted hunk ↗ jump to hunk
@@ -113,17 +113,20 @@ u32 _rtw_init_sta_priv(struct sta_priv *pstapriv)inline int rtw_stainfo_offset(struct sta_priv *stapriv, struct sta_info *sta) { int offset = (((u8 *)sta) - stapriv->pstainfo_buf) / sizeof(struct sta_info); + struct net_device *pnetdev = stapriv->padapter->pnetdev; if (!stainfo_offset_valid(offset)) - DBG_88E("%s invalid offset(%d), out of range!!!", __func__, offset); + netdev_dbg(pnetdev, "invalid offset(%d), out of range!!!", offset);
better to add terminating newlines to the formats.