Re: [PATCH] staging: rtl8712: Remove unnecessary alias of printk()
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-06-09 10:11:21
Also in:
lkml
On Sun, Jun 06, 2021 at 05:40:38AM +0200, Fabio M. De Francesco wrote:
quoted hunk ↗ jump to hunk
This module defines four alias for printk(). Removed them all, because they are not used anywhere else in the driver. Converted the only exception to the explicit use of printk(). Signed-off-by: Fabio M. De Francesco <redacted> --- drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- drivers/staging/rtl8712/rtl871x_debug.h | 23 ----------------------- 2 files changed, 1 insertion(+), 24 deletions(-)diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c index ff3cb09c57a6..e94604cb71fd 100644 --- a/drivers/staging/rtl8712/rtl8712_cmd.c +++ b/drivers/staging/rtl8712/rtl8712_cmd.c@@ -55,7 +55,7 @@ static void check_hw_pbc(struct _adapter *padapter) /* Here we only set bPbcPressed to true * After trigger PBC, the variable will be set to false */ - DBG_8712("CheckPbcGPIO - PBC is pressed !!!!\n"); + printk(KERN_DEBUG "CheckPbcGPIO - PBC is pressed !!!!\n");
As an add-on patch, you should move this to netdev_dbg() or dev_dbg(). thanks, greg k-h